Skip to content

Fix example to also normalize plus character in emails#1050

Merged
BenRKarl merged 4 commits into
googleads:mainfrom
Base3-GmbH:fix/normalize-plus-character-in-emails
Jan 6, 2026
Merged

Fix example to also normalize plus character in emails#1050
BenRKarl merged 4 commits into
googleads:mainfrom
Base3-GmbH:fix/normalize-plus-character-in-emails

Conversation

@lucasra1

@lucasra1 lucasra1 commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

Correct function to follow documentation. + characters also need to be removed and normalization is not only for gmail.com or googlemail.com addresses

https://developers.google.com/google-ads/api/docs/conversions/upload-offline#prepare-data

For email addresses:

@lucasra1 lucasra1 requested a review from a team as a code owner December 8, 2025 22:11
@google-cla

google-cla Bot commented Dec 8, 2025

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@BenRKarl

Copy link
Copy Markdown
Contributor

Thank you for submitting this PR! I'm conferring internally on some of the details here to make sure I understand the functionality. In the meantime can you look at the CLA mentioned here?

@BenRKarl BenRKarl removed the request for review from AnashOommen December 19, 2025 15:42
@lucasra1

Copy link
Copy Markdown
Contributor Author

Thank you for submitting this PR! I'm conferring internally on some of the details here to make sure I understand the functionality. In the meantime can you look at the CLA mentioned here?

If I am not mistaken I have agreed to it and rerun the GitHub Action successfully

@bobhancockg bobhancockg requested a review from BenRKarl January 5, 2026 15:03
Comment thread examples/remarketing/upload_enhanced_conversions_for_leads.py Outdated
Comment thread examples/remarketing/upload_enhanced_conversions_for_web.py Outdated
@lucasra1 lucasra1 requested a review from bobhancockg January 6, 2026 12:57
@BenRKarl BenRKarl merged commit f7ff799 into googleads:main Jan 6, 2026
2 checks passed
@grachov

grachov commented May 25, 2026

Copy link
Copy Markdown

@bobhancockg @BenRKarl Is the change in the PR correct? It currently removes only +, but not the postfix coming after it, so janedoe+newsletter@example.com becomes janedoenewsletter@example.com and not janedoe@example.com - making it completely different email.

@lucasra1 lucasra1 deleted the fix/normalize-plus-character-in-emails branch May 25, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants